Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod_posix error if prosody user ID was altered #67

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

selurvedu
Copy link
Contributor

This fixes the following error that occurs if /var/lib/prosody is not owned by UID 101.

mod_posix           error  Couldn't write pidfile at /var/run/prosody/prosody.pid; /var/run/prosody/prosody.pid: Permission denied

Maybe #63 handles permissions better, but I didn't evaluate it properly. I only saw it introduces more significant changes and it's not merged yet, while my MR doesn't really change anything. It simply fixes what #62 missed.

This fixes the following mod_posix error:

Couldn't write pidfile at /var/run/prosody/prosody.pid;
/var/run/prosody/prosody.pid: Permission denied
@mwild1 mwild1 requested review from Zash and zeen January 17, 2021 08:35
@Zash
Copy link
Member

Zash commented Jan 19, 2021

Why do you need a pidfile in Docker?

@selurvedu
Copy link
Contributor Author

@Zash I don't. Try it yourself with the default config, it is enabled by default.

@selurvedu
Copy link
Contributor Author

Also, I guess prosodyctl reload may be useful in Docker too.

@Zash Zash merged commit d627c29 into prosody:master Jan 29, 2021
@Zash
Copy link
Member

Zash commented Jan 29, 2021

YOLO-merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants